Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/TPCC #243

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Test/TPCC #243

merged 3 commits into from
Nov 12, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Nov 12, 2024

What problem does this PR solve?

add Tpcc for FnckSQL

ref: https://github.com/AgilData/tpcc

cd tpcc
cargo run --release
<RT Histogram>

1.New-Order

...

2.Payment

...

3.Order-Status

...

4.Delivery

...

5.Stock-Level

...

<90th Percentile RT (MaxRT)>
   New-Order : 0.882  (0.947)
     Payment : 0.080  (0.095)
Order-Status : 0.235  (0.255)
    Delivery : 5.386  (5.658)
 Stock-Level : 0.001  (0.002)

fix:

  • TupleIdBuilder returns None when the number of primary key values ​​does not reach the total number of values ​​to avoid returning partial primary keys.
  • avoid redundant cloning when DataValue is cast
  • Double can be converted into Decimal
  • ScalaExpression::Coalesce will take the largest type among all expressions and will not cause an exception if it is inconsistent.
  • Different types of values ​​may be generated during Update

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Nov 12, 2024
@KKould KKould added the enhancement New feature or request label Nov 12, 2024
@KKould KKould merged commit 6e35bc7 into main Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant