Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/View #236

Merged
merged 7 commits into from
Nov 3, 2024
Merged

Feat/View #236

merged 7 commits into from
Nov 3, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Nov 3, 2024

What problem does this PR solve?

feat:

  • support Create View
  • impl View as data source

fix:

  • alias is not lower_case
  • When NestLoopJoin is in Left Join, the left table will have one more row of data (the right table is null at this time)

Issue link: #188

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Nov 3, 2024
@KKould KKould mentioned this pull request Nov 3, 2024
51 tasks
@KKould KKould linked an issue Nov 3, 2024 that may be closed by this pull request
@KKould KKould merged commit 7498b21 into main Nov 3, 2024
6 checks passed
@KKould KKould deleted the feat/view branch November 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Support View
1 participant