Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add function CharLength & CharacterLength #235

Merged
merged 1 commit into from
Nov 2, 2024
Merged

feat: add function CharLength & CharacterLength #235

merged 1 commit into from
Nov 2, 2024

Conversation

wszhdshys
Copy link
Contributor

@wszhdshys wszhdshys commented Nov 2, 2024 •
edited
Loading

What problem does this PR solve?

Add function CharLength & CharacterLength

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-requested a review November 2, 2024 17:56
@KKould KKould added the enhancement New feature or request label Nov 2, 2024
KKould
KKould approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@KKould KKould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@KKould KKould merged commit ae59a91 into KipData:main Nov 2, 2024
3 checks passed
@KKould KKould mentioned this pull request Nov 3, 2024
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKould KKould KKould approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wszhdshys @KKould