Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add functions CharLength & CharacterLength #232

Closed
wants to merge 4 commits into from
Closed

feat: add functions CharLength & CharacterLength #232

wants to merge 4 commits into from

Conversation

wszhdshys
Copy link
Contributor

@wszhdshys wszhdshys commented Oct 20, 2024 •
edited
Loading

What problem does this PR solve?

Add functions CharacterLength & Charlength

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the enhancement New feature or request label Oct 21, 2024
@KKould KKould self-requested a review October 21, 2024 10:44
@KKould
Copy link
Member

KKould commented Oct 21, 2024

I think the functions of Char_Length and Character_Length are same. CharacterLength should be deleted, but when registering, you can create a FunctionSummary with a function name of CharacterLength but other functions consistent with Char_Length.

KKould
KKould reviewed Oct 21, 2024
View reviewed changes
tests/slt/sql_2016/E021_04.slt
# ----
# 3
query I
SELECT CHARACTER_LENGTH ( 'foooof' )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please restore the test content

KKould
KKould reviewed Oct 21, 2024
View reviewed changes
tests/slt/sql_2016/E021_04.slt
# ----
# 3
query I
SELECT CHAR_LENGTH ( 'foooof' )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please restore the test content too

@wszhdshys wszhdshys closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKould KKould KKould left review comments

Assignees

@wszhdshys wszhdshys

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wszhdshys @KKould