feat: switch to signal inputs #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
feat/signal-inputs
branch
from
1fdd93c
to
49212c9
Compare
|
|
||
| export const getFormat = (format?: QuillFormat, configFormat?: QuillFormat): QuillFormat => { | ||
| const passedFormat = format || configFormat | ||
| return passedFormat || 'html' | ||
| } | ||
|
|
||
| export function raf$() { |
There was a problem hiding this comment.
would be nice to use fat arrow functions
KillerCodeMonkey
requested changes
Apr 12, 2024
This commit switches inputs to signal inputs to be compatible with zoneless change detection because everything should be a signal primitive. As such, its changes may be caught by the execution context. Every time a signal changes, it would schedule a change detection event, even in zoneless mode. I didn't update `@Output()` to `output` because we still use `.observed` properties.
arturovt
force-pushed
the
feat/signal-inputs
branch
from
9f94b68
to
47c138f
Compare
|
No matter what tests I add the coverage remains the same. |
KillerCodeMonkey
approved these changes
Apr 15, 2024
|
i will check it thank you for the pr |
|
FYI: it is the coverage for branches if you run the test -> check the coverage folder there you have the text, json and html coverage reports |
|
now we get the error |
|
you need angular 17 my demo repo is up to date https://killercodemonkey.github.io/ngx-quill-example/ |
|
@andrei-varchanka, you don't need to upgrade to the latest version if you're staying with Angular versions lower than 17, as the latest changes are only compatible with ng17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches inputs to signal inputs to be compatible with zoneless change detection because everything should be a signal primitive. As such, its changes may be caught by the execution context. Every time a signal changes, it would schedule a change detection event, even in zoneless mode.
I didn't update
@Output()tooutputbecause we still use.observedproperties.