Remove iridescence thickness range error (#238)

KhronosGroup · Oct 4, 2024 · 91c9b7c · 91c9b7c
1 parent ee84629
commit 91c9b7c
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 130 deletions.
diff --git a/ISSUES.md b/ISSUES.md
@@ -48,7 +48,6 @@
 |KHR_MATERIALS_CLEARCOAT_CLEARCOAT_NORMAL_TEXTURE_TEXCOORD|Normal and clearcoat normal textures should use the same texture coords.|Warning|
 |KHR_MATERIALS_DISPERSION_NO_VOLUME|The dispersion extension needs to be combined with the volume extension.|Warning|
 |KHR_MATERIALS_EMISSIVE_STRENGTH_ZERO_FACTOR|Emissive strength has no effect when the emissive factor is zero or undefined.|Warning|
-|KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID|Thickness maximum must be greater than or equal to the thickness minimum.|Error|
 |KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_WITHOUT_TEXTURE|Thickness minimum has no effect when a thickness texture is not defined.|Information|
 |KHR_MATERIALS_IRIDESCENCE_THICKNESS_TEXTURE_UNUSED|Thickness texture has no effect when the thickness minimum is equal to the thickness maximum.|Information|
 |KHR_MATERIALS_VOLUME_DOUBLE_SIDED|The volume extension should not be used with double-sided materials.|Warning|

diff --git a/lib/src/errors.dart b/lib/src/errors.dart
@@ -547,12 +547,6 @@ class SemanticError extends IssueType {
               'when a thickness texture is not defined.',
           Severity.Information);
 
-  static final SemanticError khrMaterialsIridescenceThicknessRangeInvalid =
-      SemanticError._(
-          'KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID',
-          (args) => 'Thickness maximum must be greater than or '
-              'equal to the thickness minimum.');
-
   static final SemanticError khrMaterialsIridescenceThicknessTextureUnused =
       SemanticError._(
           'KHR_MATERIALS_IRIDESCENCE_THICKNESS_TEXTURE_UNUSED',

diff --git a/lib/src/ext/KHR_materials_iridescence/khr_materials_iridescence.dart b/lib/src/ext/KHR_materials_iridescence/khr_materials_iridescence.dart
@@ -65,13 +65,6 @@ class KhrMaterialsIridescence extends GltfProperty {
         map, IRIDESCENCE_THICKNESS_TEXTURE, context, TextureInfo.fromMap);
 
     if (context.validate) {
-      if (iridescenceThicknessMinimum > iridescenceThicknessMaximum) {
-        context.addIssue(
-            SemanticError.khrMaterialsIridescenceThicknessRangeInvalid,
-            name: map.containsKey(IRIDESCENCE_THICKNESS_MINIMUM)
-                ? IRIDESCENCE_THICKNESS_MINIMUM
-                : IRIDESCENCE_THICKNESS_MAXIMUM);
-      }
       if (iridescenceThicknessTexture != null) {
         if (iridescenceThicknessMinimum == iridescenceThicknessMaximum) {
           context.addIssue(

diff --git a/test/ext/KHR_materials_iridescence/assets.json b/test/ext/KHR_materials_iridescence/assets.json
@@ -4,7 +4,6 @@
         "tests": {
             "custom_property.gltf": "Custom property",
             "unexpected_extension.gltf": "Unexpected extension object location",
-            "invalid_thickness_range.gltf": "Invalid thickness range",
             "unused_thickness_texture.gltf": "Unused thickness texture",
             "unused_thickness_minimum.gltf": "Unused thickness minimum",
             "valid.gltf": "Valid"

diff --git a/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf b/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf
diff --git a/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf.report.json b/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf.report.json