Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epsilon to float comparison #3635

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add epsilon to float comparison #3635

merged 2 commits into from
Apr 3, 2024

Commits on Apr 3, 2024

  1. Add epsilon to float comparison 

    Adds an epsilon when comparing float values in
conformance/extensions/webgl-depth-texture.html. As-is, it is possible
for tests to fail with output such as:

At 2,0, expected within [0.2,0.6], was 0.600
FAIL At 2,0, expected within [0.2,0.6], was 0.600
    @bsheedy-work
    bsheedy-work authored and bsheedy-work committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e2f21be View commit details
    Browse the repository at this point in the history

  2. Uniformly apply epsilon 

    Removes the epsilon value added to certain parts of the expected min/max
values in conformance/extensions/webgl-depth-texture.html, instead using
only the epsilon applied when actually comparing values.
    @bsheedy-work
    bsheedy-work committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7b58145 View commit details
    Browse the repository at this point in the history