New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify invalidated uniform locations when there is no current program. #3633

Merged

kenrussell merged 1 commit into KhronosGroup:main from kenrussell:uniform-location-relinking

Apr 2, 2024

Member

kenrussell commented Apr 2, 2024

Associated with crbug.com/331119482 .


          Verify invalidated uniform locations when there is no current program.

c5154bc

Associated with crbug.com/331119482 .

kenrussell requested review from kdashg and greggman

April 2, 2024 21:12

kdashg approved these changes

View reviewed changes

kenrussell merged commit 4c5b8bf into KhronosGroup:main

2 checks passed

kenrussell deleted the uniform-location-relinking branch

April 2, 2024 21:17

aarongable pushed a commit to chromium/chromium that referenced this pull request


          Refactor uniform location validation.

997d3f8

If there was no current program in the WebGL context, validation would
be incorrect after program relinking.

Tested with revised WebGL conformance test from
KhronosGroup/WebGL#3633 .

Fixed: 331119482
Change-Id: I06b11ab41930a2d1844432b2c740e090f0994b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5415259
Reviewed-by: Brandon Jones <[email protected]>
Commit-Queue: Brandon Jones <[email protected]>
Auto-Submit: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1281535}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet