Fix EXT_texture_compression_s3tc dependency in EXT_texture_sRGB_decode #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdaniell-nv
force-pushed
the
341-issue
branch
2 times, most recently
from
4eb83e1
to
0c9a5c1
Compare
|
This looks fine to me as far as S3TC is concerned, but I think Section 3.8.15 also misses listing the ETC2/ASTC texture formats, but thats certainly scope of another ticket/pull request. |
|
LGTM. Mark Approved when ready to merge. |
|
We discussed this PR in the OpenGL/ES meeting today and we're not sure if this change is even needed. I'll follow up in the #341 issue. |
|
I think this change is not needed as the extension already has a dependency on GL_EXT_texture_srgb, or OpenGL 2.1, where GL_EXT_texture_srgb was incorporated in the core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #341