-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Input Numbers in Explanation Widgets #1900
base: main
Are you sure you want to change the base?
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (bd376eb) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1900 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1900 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the talk in the huddle, this looks good to me. Good to go once the checks pass :) Love the safety measures :D Might be good to make sure this fixes the errors too ^_^
Size Change: +108 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
Could you attach a representative piece of data to this PR for posterity? I also don't really understand the issue based on the description. Even if you come back after the p0 event is over, I'd love to see this PR filled out a bit more for historical purposes. |
Summary:
This PR implements a quick bug fix for a p0 issue related to explanation widget, as it does not follow the typical PerseusRenderer format. I've also added some extra safety checks.
Test plan: