-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor : image 패키지 생성 & 프론트 요구사항 반영 #407
Merged
GBGreenBravo
merged 20 commits into
Kernel360:develop
from
GBGreenBravo:refactor/#406_Image_Package_&_Crew_Default_Image
Apr 9, 2024
Merged
Refactor : image 패키지 생성 & 프론트 요구사항 반영 #407
GBGreenBravo
merged 20 commits into
Kernel360:develop
from
GBGreenBravo:refactor/#406_Image_Package_&_Crew_Default_Image
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBGreenBravo
added
🎸Chore
기타 변경사항 (빌드 스크립트 수정, 패키지 매니징 설정 등)
💻 BE
백엔드
🔨 Refactor
코드를 리팩토링한 경우
labels
Mar 26, 2024
GBGreenBravo
changed the title
Refacto : image 패키지 생성 & 크루 default-image 반영
Refactor : image 패키지 생성 & 크루 default-image 반영
Mar 26, 2024
GBGreenBravo
changed the title
Refactor : image 패키지 생성 & 크루 default-image 반영
Refactor : image 패키지 생성 & 금일 프론트 요구사항 반영
Mar 26, 2024
c0olcode
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영 내용 확인했습니다 감사합니다 :)
내 가입/신청 크루 목록 조회 API를 구현할 때,
|
GBGreenBravo
changed the title
Refactor : image 패키지 생성 & 금일 프론트 요구사항 반영
Refactor : image 패키지 생성 & 프론트 요구사항 반영
Apr 1, 2024
oxix97
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~~~
orury-client/src/main/java/org/orury/client/crew/application/CrewServiceImpl.java
Show resolved
Hide resolved
orury-client/src/main/java/org/orury/client/meeting/application/MeetingServiceImpl.java
Show resolved
Hide resolved
kkkapuq
approved these changes
Apr 9, 2024
orury-client/src/main/java/org/orury/client/crew/application/CrewService.java
Show resolved
Hide resolved
orury-client/src/main/java/org/orury/client/crew/application/CrewServiceImpl.java
Show resolved
Hide resolved
oxix97
approved these changes
Apr 9, 2024
GBGreenBravo
deleted the
refactor/#406_Image_Package_&_Crew_Default_Image
branch
April 9, 2024 06:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
기존의 ImageStore/ImageReader은 global 패키지 하위에,
ImageStoreImpl/ImageReaderImpl이 post 패키지 하위에 있어,
이를 image 패키지를 생성하여 정리했습니다.
Image 조회/삭제 시, default-crew-icon이 정상 반영(기본 조회 / 삭제 면역)되도록 수정했습니다.
그리고 아래의 금일 프론트 요구사항에 대해서도 반영했고, 빗금치지 않은 부분은 반영 안된 사항들입니다.
(2024/04/01) 크루멤버목록 조회 API 구현 & 일정멤버목록 조회 API 리팩토링 진행했습니다.
closed #406
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.