KSM-458 - Python SDK - remove core dep on helper #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new Ansible action to retrieve records from the Vault and
create a encrypted serialized cache. This cache can then be set on
the attributes of the existing action. If set, the existing actions
will use the records in the cache. However, if the action uses
notation, the cache will not work. The KSM SDK notation method
needs to be changed to allow a list of Record to be passed in. Right
now it always get record from the Keeper Vault.
The new action `keeper_cache_records` takes a list of UID and/or titles.
```yaml
tasks:
- name: Generate a Keeper Record Cache secret
keeper_password:
length: 64
register: keeper_record_cache_secret
no_log: True
- name: Store the Keeper Record Cache secret into variables.
set_fact:
keeper_record_cache_secret: "{{ keeper_record_cache_secret.password }}"
no_log: True
- name: Cache records. Will use keeper_record_cache_secret from above.
keeper_cache_records:
uids:
- RECORD UID 1
- RECORD UID 2
titles:
- TITLE 1
- TITLE 2
register: my_records
no_log: True
- name: "Get Value By UID"
keeper_get:
cache: "{{ my_records.cache }}"
uid: RECORD UID 1
field: "password"
register: "my_password_by_uid"
```
Bonus changes
* Added the ability to select records by title to the `keeper_get`, `keeper_set`, and
`keeper_copy` actions.
* Added a non-notation selectors for complex field values. The attributes
`array_index` and `value_key` allow selecting which object/value in an array
and key/value pair for dictionaries.
* Updated the test framework. Changes in Ansible broke our test framework.
jwalstra-keeper
force-pushed
the
KSM-458_remove_core_dep_on_helper
branch
from
4c8df38
to
e54d5c0
Compare
Refactor add_custom_field not to use the helper module. The method will accept an instance of FieldType, however it is not tied to the keeper_secrets_manager_helper.v3.field_type.FieldType module. Allow the ability to set the type, label, and value not using the FieldType instance. The method will still take the param `field`, however it will also take `field_type`, `label`, and `value`. This allows adding a custom field without have to use the helper module. Removed references `keeper-secrets-manager-helper` from setup.py and requirements.txt. This should break the circular reference. Added unit tests for the method.
jwalstra-keeper
force-pushed
the
KSM-458_remove_core_dep_on_helper
branch
from
e54d5c0
to
ee89659
Compare
idimov-keeper
approved these changes
Aug 22, 2023
maksimu
changed the title
maksimu
changed the title
maksimu
changed the base branch from
master
to
release/sdk/python/core/v16.6.2
maksimu
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.