Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes. #17

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Build fixes. #17

merged 1 commit into from
Sep 13, 2024

Conversation

amigus
Copy link
Collaborator

@amigus amigus commented Sep 12, 2024

  • Set the version via the environment
  • Update upload and download-artifacts to v4

name: Pull request
about: If you have a pull request to fix a bug or add a feature

Pull request checklist

Please check if your PR fulfills the following requirements:

  • You have read the contributing guide
  • Tests for the changes have been added
  • The documentation has been reviewed and updated as needed

What is the current behavior?

The version is incorrect--it appears as the git describe command.

What is the new behavior?

The version is correct on binaries built via GitHub actions

Does this introduce a breaking change?

  • Yes
  • No

- Set the version via the environment
- Update upload and download-artifacts to v4
@amigus amigus self-assigned this Sep 12, 2024
@amigus amigus requested a review from maksimu September 12, 2024 20:58
@amigus amigus merged commit 2b81e22 into main Sep 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants