Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cgo-build matrix strategy to target multiple platforms. #12

Merged
merged 9 commits into from
Sep 11, 2024
Merged

Use cgo-build matrix strategy to target multiple platforms. #12

merged 9 commits into from
Sep 11, 2024

Conversation

amigus
Copy link
Collaborator

@amigus amigus commented Sep 9, 2024

name: Pull request
about: If you have a pull request to fix a bug or add a feature

Pull request checklist

Please check if your PR fulfills the following requirements:

  • You have read the contributing guide
  • Tests for the changes have been added
  • The documentation has been reviewed and updated as needed

What is the current behavior?

  • The build is not matrixed and targets only one architecture
  • The build does not include a version flag

What is the new behavior?

  • The build now supports amd64 and arm64 on GLIBC and musl
  • The build now passes a version flag

Does this introduce a breaking change?

  • Yes
  • No

@amigus amigus mentioned this pull request Sep 10, 2024
Merged
5 tasks
@amigus amigus self-assigned this Sep 10, 2024
@amigus amigus requested a review from maksimu September 10, 2024 15:55
@amigus amigus merged commit 649e79c into main Sep 11, 2024
2 of 3 checks passed
@amigus amigus deleted the mbuild-pr branch September 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksimu maksimu maksimu approved these changes

Assignees

@amigus amigus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amigus @maksimu