Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] security code 개선 #93

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[REFACTOR] security code 개선 #93

merged 1 commit into from
Aug 7, 2023

Conversation

unanchoi
Copy link
Contributor

@unanchoi unanchoi commented Aug 7, 2023 •
edited
Loading

📝 Summary

  • Swagger와 token 검증 하지 않는 API가 동작하도록 code를 수정했습니다!

👩‍💻 Contents

  • WebSecurityCustomizer를 securityFilterChain 내부 method로 대체했습니다. -> 실행할 때, 권장하지 않는 다는 WARN 로그가 출력되어 변경했습니다.
  • Access Token의 Signature를 Claims 안에 담아두도록 리팩토링 했습니다.
  • Swagger와 token 검증이 필요없는 api의 경우, 검증 없이 요청이 되도록 수정했습니다.

📝 Review Note

  • Security 어렵다.

📣 Related Issue

📬 Reference

@unanchoi unanchoi self-assigned this Aug 7, 2023
yeseul106
yeseul106 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@yeseul106 yeseul106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와아아우 ! 고생하셨습니다아 ~

@yeseul106 yeseul106 merged commit 40c80df into develop Aug 7, 2023
1 check passed
Seokyeong237
Seokyeong237 reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@Seokyeong237 Seokyeong237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨씁니다!

@unanchoi unanchoi deleted the refactor/88-security branch November 9, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seokyeong237 Seokyeong237 Seokyeong237 left review comments

@yeseul106 yeseul106 yeseul106 approved these changes

Assignees

@unanchoi unanchoi

Labels
🐻 윤한 🐻 🛠️Refactor🛠️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] Security Code 개선
3 participants
@unanchoi @Seokyeong237 @yeseul106