[FIX] 공유용 출력 뷰에서 공유한 유저가 작성한 카테고리 목록을 조회할 수 있도록 수정 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
👩💻 Contents
현재 카테고리를 조회하는 api는 토큰의 payload에 담겨있는 memberId를 꺼내서 해당 멤버가 작성한 카테고리만 조회하도록 구현되어 있습니다.
하지만 공유용 뷰에서 카테고리를 조회할 때는 공유를 한 사람이 작성한 카테고리가 보여야 하므로 path parameter로 조회하고자 하는 유저의 id를 받도록 수정하였습니다.
이 과정에서 로그인 성공 시, 내려주는 response body에 memberId도 추가해서 내려줄 수 있도록 수정하였습니다.
로그인 성공 시, memberId도 추가해서 내려주는 것 확인
테스트 화면
📝 Review Note
📣 Related Issue
📬 Reference