Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 업무카드 수정 API #200

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[Fix] 업무카드 수정 API #200

merged 2 commits into from
Nov 9, 2023

Conversation

unanchoi
Copy link
Contributor

@unanchoi unanchoi commented Nov 8, 2023

📝 Summary

업무 카드 수정 API 요청시에, 요청이 제대로 들어가지 않는 문제 수정

👩‍💻 Contents

  • CardServiceImpl의 updateCard 에서 ScreenshotName도 함께 저장하도록 수정했습니다.

Test한 API 요청 첨부합니다.
image

리뷰 노트

📣 Related Issue

📬 Reference

@unanchoi unanchoi added 🐻 윤한 🐻 🐞Fix🐞 에러 발생 시, 버그 labels Nov 8, 2023
@unanchoi unanchoi self-assigned this Nov 8, 2023
Seokyeong237
Seokyeong237 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Seokyeong237 Seokyeong237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다!

yeseul106
yeseul106 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@yeseul106 yeseul106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

@unanchoi unanchoi merged commit d4a1ba7 into develop Nov 9, 2023
1 check passed
@unanchoi unanchoi deleted the fix/#198 branch November 9, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeseul106 yeseul106 yeseul106 approved these changes

@Seokyeong237 Seokyeong237 Seokyeong237 approved these changes

Assignees

@unanchoi unanchoi

Labels
🐞Fix🐞 에러 발생 시, 버그 🐻 윤한 🐻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 업무카드 수정 API 로직 수정
3 participants
@unanchoi @Seokyeong237 @yeseul106