Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 파일 & 스크린샷 삭제 API #124

Merged
merged 6 commits into from
Aug 25, 2023
Merged

[FEAT] 파일 & 스크린샷 삭제 API #124

merged 6 commits into from
Aug 25, 2023

Conversation

Seokyeong237
Copy link
Member

@Seokyeong237 Seokyeong237 commented Aug 24, 2023 •
edited by yeseul106
Loading

📝 Summary

  • 파일 삭제 API 구현
  • 스크린샷 삭제 API 구현

👩‍💻 Contents

  • 파일 삭제 API 요청 시, DB에서도 삭제하고 s3에서도 삭제하도록 구현했습니다.
  • 스크린샷 삭제 API 요청 시, DB에서도 삭제하고 s3에서도 삭제하도록 구현했습니다.
  • 이 과정에서 객체 key 값으로 삭제해야해서 스크린샷과 파일 테이블에 해당 컬럼을 추가했습니다.

📝 Review Note

📣 Related Issue

📬 Reference

@Seokyeong237 Seokyeong237 self-assigned this Aug 24, 2023
@yeseul106 yeseul106 changed the title [FEAT] 파일 삭제 API [FEAT] 파일 & 스크린샷 삭제 API Aug 24, 2023
unanchoi
unanchoi approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@unanchoi unanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

@Seokyeong237 Seokyeong237 merged commit 8c209ba into develop Aug 25, 2023
1 check passed
@Seokyeong237 Seokyeong237 deleted the feat/#120-file-download branch November 21, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unanchoi unanchoi unanchoi approved these changes

@yeseul106 yeseul106 Awaiting requested review from yeseul106

Assignees

@Seokyeong237 Seokyeong237

Labels
✨Feat✨ 🐹 서경 🐹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 파일 & 스크린샷 삭제 API 구현
3 participants
@Seokyeong237 @unanchoi @yeseul106