[FEAT] 파일 PreSigned-Url 발급 API 개발 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unanchoi
requested changes
Aug 24, 2023
| @ApiResponse(responseCode = "500", description = "서버 오류", content = @Content) | ||
| } | ||
| ) | ||
| @PostMapping("/files/presigned") |
There was a problem hiding this comment.
p3;
presigined-url 발급 자체가 서버 리소스의 변화를 일으키지는 않는 것 같은데 POST보다는 GET API를 만드는 것이 어떨까요?
There was a problem hiding this comment.
넵 확인했습니다 ! HTTP의 정신 !!!!!
| } | ||
| ) | ||
| @PostMapping("/files/presigned") | ||
| @ResponseStatus(HttpStatus.OK) |
There was a problem hiding this comment.
p2;
statusCode와 @ResponseStatus 가 일치하지 않습니다~!
| private String url; | ||
|
|
||
| @Schema(description = "파일 사이즈", example = "2.1") | ||
| private Double size; |
There was a problem hiding this comment.
p4;
file size에 Double을 사용하신 이유가 있는지 궁금합니다!
There was a problem hiding this comment.
확인 ! KB 기준으로 int로 바꾸겠습니다 !
unanchoi
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
👩💻 Contents
📝 Review Note
📣 Related Issue
📬 Reference