[REFACTOR] response body 구조 개선 및 단건 조회 로직 구현부 변경 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeseul106
commented
Aug 12, 2023
| @@ -38,11 +37,11 @@ public ApiResponseDto<AuthLoginResponseDto> socialLogin(@RequestBody AuthRequest | |||
|
|
|||
| // 로그인 | |||
| if (!responseDto.isNewUser()) { | |||
| return ApiResponseDto.success(SuccessStatus.SIGNIN_SUCCESS, responseDto); | |||
There was a problem hiding this comment.
그리고 여기 제가 리팩토링 하면서 발견한 부분이긴 한데 ,,,!
if절과 else절로 나눈 이유가 내려주는 data의 형식은 같은데, 단순히 SuccessStatus 값의 차이 때문이었던걸로 판단했는데, 맞을까요 ?? @Seokyeong237
그 이유 때문이라면 지금 저희 response body는 message가 들어가지 않기 때문에 if-else 문으로 나눌 필요 없을 것 같은데 어떻게 생각하실까요 ?
There was a problem hiding this comment.
@yeseul106 헉 요거 놓쳤네요 :( 맞아요 이제 나눌 필요 없습니다 수정해주셔서 감사해용 ㅎㅎ
unanchoi
approved these changes
Aug 12, 2023
| .status(status.getHttpStatus().value()) | ||
| .success(true) | ||
| .message(status.getMessage()) | ||
| .status("SSS") |
There was a problem hiding this comment.
p3;
클래스 변수로 선언해주시는 것이 좋을 것 조금 더 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
👩💻 Contents
📝 Review Note
📣 Related Issue
📬 Reference