Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local repository higher priority than default #96

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

HebaruSan
Copy link
Member

Problem

KSP-CKAN/NetKAN#9806 is failing validation because the validator is trying to install the old version of the module, without the PR's changes:

https://github.com/KSP-CKAN/NetKAN/actions/runs/6249249066/job/16965475746?pr=9806

image

https://github.com/KSP-CKAN/NetKAN/pull/9806/files

Cause

The validator adds the changes as a repo named local, and its priority ends up being 1, with the default repo remaining 0 priority. This means the default version of the module takes precedence.

This worked previously because priority was not used and the sort was alphabetical, so default was overridden by local.

Changes

Now we set the priority of the local repo to 0, so the PR's changes will override the default repo.

I'll self-review this so I can see if it helps that PR.

@HebaruSan HebaruSan added the Bug label Sep 20, 2023
@HebaruSan HebaruSan merged commit 4498fe4 into KSP-CKAN:master Sep 20, 2023
2 checks passed
@HebaruSan HebaruSan deleted the fix/repo-priority branch September 20, 2023 15:24
@HebaruSan
Copy link
Member Author

Worked.

https://github.com/KSP-CKAN/NetKAN/actions/runs/6249249066/job/16970655335

(The validator doesn't install virtual dependencies, unfortunately.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant