Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopting ALCOR and pointing it at my new version #9834

Merged
merged 3 commits into from
Nov 8, 2023
Merged

adopting ALCOR and pointing it at my new version #9834

merged 3 commits into from
Nov 8, 2023

Conversation

JonnyOThan
Copy link
Contributor

note that the new version includes the IVA instead of keeping a separate package, so I've marked the old IVA pack as a conflict

note that the new version includes the IVA instead of keeping a separate package, so I've marked the old IVA pack as a conflict
@JonnyOThan
Copy link
Contributor Author

uhhh not really sure what's wrong here :/

@HebaruSan
Copy link
Member

uhhh not really sure what's wrong here :/

A C# exception generally means there's a formatting problem for which there's no explicit check. One moment...

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Are you planning to update the recommendations/supports to match the lists on the repo? If not, then this looks ready to merge to me, but I'll hold off just in case you were planning that.

@JonnyOThan
Copy link
Contributor Author

Hmm, let's leave the netkan as-is for now; most of the stuff in the readme on github is inherited from the old version and I haven't cross-checked.

@HebaruSan HebaruSan merged commit 221f773 into KSP-CKAN:master Nov 8, 2023
1 check passed
@JonnyOThan JonnyOThan deleted the patch-18 branch November 8, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants