Add ROUtils and RONoCareer #9831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that was fun. Apparently using github.dev created wrong line endings when I did save-as on an existing metanetkan to create these. In the end I had to nuke and recreate both files using the old web interface. (Slightly weird the inflation bot doesn't accept \r\n though!) |
NathanKell
force-pushed
the
NewROMods
branch
from
2dd1772
to
20d7ced
Compare
|
Is there anything else that needs doing here? There's multiple KSP-RO mod releases blocked on this being merged so it'd be awesome if folks could let me know if any changes are needed so this can go in. I'm also happy to merge this myself if folks are busy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HebaruSan for once I actually made the mods (including netkan!) before making the PR. Woot!
(FYI the plan for these are that ROUtils will be a dependency for most KSP-RO mods, but should not be installed on its own; and RONoCareer will go into the express install in an any_of with RP-1 so that folks can choose to install RO but not RP-1, finally. It's purely a stub so the any_of can work, so it doesn't actually do anything other than exist and be findable by CKAN.)