Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress recs on CKAN-hosted netkans for RO group mods #9804

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Suppress recs on CKAN-hosted netkans for RO group mods #9804

merged 3 commits into from
Sep 19, 2023

Conversation

NathanKell
Copy link
Contributor

@NathanKell NathanKell marked this pull request as draft September 19, 2023 20:08
@NathanKell
Copy link
Contributor Author

I left spec version at 1.26 where it was, and upgraded it to 1.26 where it was lower than that, but does suppress recs need a higher spec version? If so I'll make that change here and also all the remote netkans.

@HebaruSan
Copy link
Member

HebaruSan commented Sep 19, 2023 •
edited
Loading

No; suppress_recommendations will be part of the v1.34 spec, but its presence does not break previous clients, so no change to spec_version is needed.

@NathanKell
Copy link
Contributor Author

Thanks! Ok then I think I hit everything here + remote.

@NathanKell NathanKell marked this pull request as ready for review September 19, 2023 20:20
HebaruSan
HebaruSan approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! 🎆

@HebaruSan HebaruSan merged commit 624f398 into master Sep 19, 2023
1 check passed
@HebaruSan HebaruSan deleted the ROSuppressRecs branch September 19, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HebaruSan HebaruSan HebaruSan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanKell @HebaruSan