fix: validate bids order #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkaroraa
force-pushed
the
fix-validate-bids
branch
from
3c3d24b
to
b66ab4c
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return nonceResults.reduce((acc, { bidder, nonce, isNonceUsed }) => { | ||
| acc[`${bidder}-${nonce}`] = isNonceUsed | ||
| return acc | ||
| }, {} as { [key: string]: boolean }) |
There was a problem hiding this comment.
Question from my javascript ignorance: do we need to give {} as { [key : string]: boolean} for the initial value of the accumulator or could we just give empty array for the reduce?
There was a problem hiding this comment.
here we are dealing with objects, so need to give empty object ie {}. if it'd have been an array, then empty array would have worked
There was a problem hiding this comment.
that makes sense but would it work if we just gave it {} like
return nonceResults.reduce((acc, { bidder, nonce, isNonceUsed }) => {
acc[`${bidder}-${nonce}`] = isNonceUsed
return acc
}, {})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task:
Fix "validate bids" order
Description
Using Promise.all doesn't guarantee the order in which the promises are going to be resolved. Whichever gets the response first, gets resolved first. As a result of that, the value of filledAmt was getting increased in a random order.
We made this change to incorporate async nonce checks.
Fix is to separately get the nonce check and then synchronously filter the bids in the order that they are supposed to.
Fixes ENG-2045
Type of change