Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Overview
colcon build
not going through.Detail
pcl_ros/point_cloud.h
is incorrect and the correct name ispcl_ros/point_cloud.hpp
. However, as mentioned below,pcl_ros/point_cloud.hpp
is not yet implemented and the build will not pass. For this issue, only commenting it out improved it and did not interfere with its functioning.ROS2 Port ros-perception/perception_pcl#225 (comment)
r_min
,r_max
andmax_fit_error
, which had not been declared.https://docs.ros.org/en/galactic/Releases/Release-Dashing-Diademata.html#declaring-parameters:~:text=As%20of%20Dashing%2C%20parameters%20now%20need%20to%20be%20declared%20before%20being%20accessed%20or%20set.
latch
has been removed as it is not used in this code.Test
Attention