Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ros2 build param issues #1

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

Alpaca-zip
Copy link

@Alpaca-zip Alpaca-zip commented Nov 12, 2023

PR Type

  • Feature
  • Bug fix
  • Refactor
  • Documentation
  • Other

Overview

  • Fixes problems with colcon build not going through.
  • Fixes problems with access to parameters.
  • Delete unused parameter.

Detail

Test

  • I have tested this change with gazebo

Attention

  • マージしてもブランチは削除しないよう注意お願いします。

@Alpaca-zip Alpaca-zip self-assigned this Nov 12, 2023
@Alpaca-zip Alpaca-zip added the bug Something isn't working label Nov 12, 2023
@Alpaca-zip Alpaca-zip marked this pull request as ready for review November 12, 2023 11:45
@shunki1006 shunki1006 merged commit e20e73b into main Nov 13, 2023
@Alpaca-zip Alpaca-zip deleted the fix/ros2-build-param-issues branch November 13, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants