Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "Validate" to "Confirm" to avoid the English language police #70

Merged
merged 1 commit into from
May 7, 2024

Conversation

Julien-cpsn
Copy link
Owner

No description provided.

@Julien-cpsn Julien-cpsn linked an issue May 7, 2024 that may be closed by this pull request
@Julien-cpsn Julien-cpsn merged commit 2305ad4 into main May 7, 2024
2 checks passed
@Julien-cpsn Julien-cpsn deleted the 69-validate-should-be-confirm branch May 7, 2024 17:54
@ccoVeille
Copy link
Contributor

You made me laugh so much with "to avoid English police" 🤣😅😂

@Julien-cpsn
Copy link
Owner Author

@ccoVeille haha I said this because I personally know @airone01 we are both from Lyon

@ccoVeille
Copy link
Contributor

@ccoVeille haha I said this because I personally know @airone01 we are both from Lyon

Villeurbanne, here ! Grand Lyon represents !

@Julien-cpsn
Copy link
Owner Author

Julien-cpsn commented May 7, 2024

Yes Villeurbanne too :)

PS : the issue number is 69

@airone01
Copy link
Contributor

airone01 commented May 7, 2024

PS : the issue number is 69

LMAO I didn't see that 😂 that's awesome

@ccoVeille
Copy link
Contributor

People who are not from France, won't get the joke, and I will think about dirty things, haha

https://en.wikipedia.org/wiki/Rh%C3%B4ne_(department)

Department number 69

@guruor
Copy link

guruor commented May 11, 2024

This change caused issue with vim bindings, getting below error when running atac:

Error:
	Could not parse key bindings file
	TOML parse error at line 19, column 1
   |
19 | [keybindings.generic.text_inputs.text_input]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing field `validate`

@Julien-cpsn
Copy link
Owner Author

This change caused issue with vim bindings, getting below error when running atac:

Error:
	Could not parse key bindings file
	TOML parse error at line 19, column 1
   |
19 | [keybindings.generic.text_inputs.text_input]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
missing field `validate`

Hello,

Which version are you using?

@guruor
Copy link

guruor commented May 12, 2024

Had installed latest version from homebrew:

atac 0.15.1

Using vim bindings file mentioned in repo:
https://github.com/Julien-cpsn/ATAC/blob/main/key_bindings_templates/vim_key_bindings.toml

# Collection name, request name, URL, Header, Query param, Basic Auth, Bearer Token
[keybindings.generic.text_inputs.text_input]
cancel = "Esc"
# confirm = "Enter" # -> This is causing issue
validate = "Enter" # -> This fixes issue

@Julien-cpsn
Copy link
Owner Author

Hello @G0V1NDS

I understand the issue, the commit that changes "validate" into "confirm" is not released yet but is on the main branch. Since you installed the app with homebrew, you don't have the other files linked to the app, so you got to the main branch, unfortunately it's not the great version of the file!

It's temporary until the new release then!
I didn't not think of that

Have a great day

@guruor
Copy link

guruor commented May 12, 2024

Understood, Anyways I stopped using vim bindings so problem is sorted for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Validate" should be "Confirm"
4 participants