Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started trying out this package to interact with the GitLab API on a self-hosted instance and encountered an error when trying to use the 2 argument
@json
macro to add things endpoints and types to the GitLabAPI.I believe the type check in the 2 argument
@json
macro is wrong, as the APIs seems to be of typeForge
rather thanForgeType
.This is based on the 1 argument definition of
@json
(which calls the same 2-argument functionjson
as the 2-argument macro):GitForge.jl/src/helpers.jl
Lines 21 to 28 in f8df114
which simply extracts the struct
$(ModuleName)API
which always seems of typeForge
rather thanForgeType
:GitForge.jl/src/forges/GitLab/GitLab.jl
Line 83 in f8df114
GitForge.jl/src/forges/GitHub/GitHub.jl
Line 79 in f8df114