Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename _convert to maybe_encode #64

Merged
merged 3 commits into from
Jul 7, 2020
Merged

rename _convert to maybe_encode #64

merged 3 commits into from
Jul 7, 2020

Commits on Jul 6, 2020

  1. rename _convert to maybe_encode 

    * add tests for maybe_encode
* ignore CRLF/LF differences
    @johnnychen94
    johnnychen94 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    fe29f97 View commit details
    Browse the repository at this point in the history

  2. revert encode of string objects for non-text formats 

    It has no practical usage except that it's conceptually right.
    @johnnychen94
    johnnychen94 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    896d4bc View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. apply suggestions from comments 

    Co-authored-by: Lyndon White <[email protected]>
    @johnnychen94 @oxinabox
    johnnychen94 and oxinabox committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    f7a8cc8 View commit details
    Browse the repository at this point in the history