[WIP] Add the match_reference function, and then refactor test_reference to call match_reference under the hood
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` to call `match_reference` under the hood
There was a problem hiding this comment.
Looks quite good to me already.
We can also move the docstring from test_reference to match_reference and then export this function as the recommended interface. Meanwhile, the @test_reference macro can still be kept as a legacy usage (no need to deprecate IMO).
The side-effect in match_reference that generates the reference file when it doesn't exist might cause some confusion; might need to add a keyword gen_reference=true to make it an opt-out feature. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.