Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline adding a new dataset #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frankier
Copy link

  • Add instructions to README for adding a new dataset
  • Add scripts to update the dataset metadata
  • Add update_doc method to only add a single dataset
  • Add HTML documentation generation to update_doc
  • Change update_doc to correctly round trip quotes in the metadata CSV

 * Add instructions to README for adding a new dataset
 * Add scripts to update the dataset metadata
 * Add update_doc method to only add a single dataset
 * Add HTML documentation generation to update_doc
 * Change update_doc to correctly round trip quotes in the metadata CSV
@frankier
Copy link
Author

Partially addresses #47 (comment) and #127 which both mention wanting further instruction on how to add a dataset.

@codecov-commenter
Copy link

Codecov Report

Base: 83.33% // Head: 81.48% // Decreases project coverage by -1.85% ⚠️

Coverage data is based on head (ebcbfef) compared to base (b1a5959).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   83.33%   81.48%   -1.86%     
==========================================
  Files           3        3              
  Lines          24       27       +3     
==========================================
+ Hits           20       22       +2     
- Misses          4        5       +1     
Impacted Files Coverage Δ
src/dataset.jl 85.71% <66.66%> (-5.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asinghvi17 asinghvi17 mentioned this pull request Apr 2, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants