Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test benchmarks from forks #96

Closed

Conversation

andreasnoack
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (e905c08) to head (eaa37a9).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   85.90%   85.90%           
=======================================
  Files           2        2           
  Lines         220      220           
=======================================
  Hits          189      189           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack andreasnoack force-pushed the andreasnoack-patch-1 branch 2 times, most recently from 42ca631 to 3eca20e Compare August 30, 2024 06:45
@andreasnoack
Copy link
Member Author

@palday I've browsed the GitHub Actions documentation and I don't see a way to allow PRs from forks be allowed to write a comment on the PR with the results. Any ideas?

@palday
Copy link
Member

palday commented Sep 3, 2024

Hmmm, we may want to have the output just included in a normal CI log that we then have to click on, like test outputs. We could also have the job pass/fail based on some liberal threshold for non-worsening performance. Liberal because benchmarking, especially on CI, tends to be very noisy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants