fixed ARI (fixes #225 & #226) #227

wildart · 2021-12-25T19:28:30Z

added pair confusion matrix (CM) calculations
fixed ARI calculation using CM

codecov-commenter · 2021-12-25T19:33:35Z

Codecov Report

Base: 95.18% // Head: 95.12% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (fc57919) compared to base (82821e8).
Patch coverage: 90.47% of modified lines in pull request are covered.

❗ Current head fc57919 differs from pull request most recent head 945c537. Consider uploading reports for the commit 945c537 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   95.18%   95.12%   -0.06%     
==========================================
  Files          16       17       +1     
  Lines        1328     1333       +5     
==========================================
+ Hits         1264     1268       +4     
- Misses         64       65       +1

Impacted Files	Coverage Δ
src/confusion.jl	`83.33% <83.33%> (ø)`
src/randindex.jl	`100.00% <100.00%> (+5.55%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

wildart · 2021-12-25T19:50:12Z

As rand behavior changed in recent julia versions, the rework of RNG handling or a test review is required.

pcjentsch · 2022-09-08T19:13:32Z

This PR passes the relevant tests, can it be merged?

This is an old bug that has had other PRs to fix it: #99

ararslan · 2022-09-10T01:55:39Z

Looks like tests are passing except for 32-bit Linux. I wonder if the forced conversion to Int in confusion means that something in randindex overflows when Int is only half as big.

test/randindex.jl

- added pair confusion matrix (CM) calculations - fixed ARI calculation using CM

pcjentsch · 2022-09-23T19:40:12Z

Hm, not sure why that change broke the test. Sorry about that, I did test it locally before suggesting it and it was fine.

alyst

Thanks for the PR!
Looks good. Could you please implement the suggestions (which are basically just formatting improvements)?

doc/source/validate.md

src/confusion.jl

src/randindex.jl

test/randindex.jl

alyst · 2023-03-19T23:23:27Z

@wildart So sorry I overlooked your updates! Thank you!

for very large clusterings the agreement/disagreement counts are very large, so we have to switch to float when multiplying them fixes #225 enhances #227

wildart mentioned this pull request Dec 25, 2021

Added pair counting fmeasure metric #220

Open

wildart force-pushed the cm branch from 2bf8d18 to a9d69ae Compare December 25, 2021 20:14

ararslan closed this Sep 10, 2022

ararslan reopened this Sep 10, 2022

pcjentsch reviewed Sep 11, 2022

View reviewed changes

test/randindex.jl Outdated Show resolved Hide resolved

wildart added 2 commits September 23, 2022 14:34

fixed ARI (fixes JuliaStats#225 & JuliaStats#226)

a661450

- added pair confusion matrix (CM) calculations - fixed ARI calculation using CM

fix test for x86

f773f92

wildart force-pushed the cm branch from a9d69ae to f773f92 Compare September 23, 2022 18:39

remove commented code

563014a

alyst reviewed Sep 23, 2022

View reviewed changes

PR corrections

945c537

wildart force-pushed the cm branch from fc57919 to 945c537 Compare September 24, 2022 00:46

alyst merged commit 5d1ad38 into JuliaStats:master Mar 19, 2023

alyst added a commit that referenced this pull request Mar 20, 2023

randindex(): fix int overflow

56bafb0

for very large clusterings the agreement/disagreement counts are very large, so we have to switch to float when multiplying them fixes #225 enhances #227

alyst mentioned this pull request Mar 20, 2023

randindex(): fix int overflow #243

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed ARI (fixes #225 & #226) #227

fixed ARI (fixes #225 & #226) #227

wildart commented Dec 25, 2021

codecov-commenter commented Dec 25, 2021 •

edited

Loading

wildart commented Dec 25, 2021

pcjentsch commented Sep 8, 2022

ararslan commented Sep 10, 2022

pcjentsch commented Sep 23, 2022 •

edited

Loading

alyst left a comment

alyst commented Mar 19, 2023

fixed ARI (fixes #225 & #226) #227

fixed ARI (fixes #225 & #226) #227

Conversation

wildart commented Dec 25, 2021

codecov-commenter commented Dec 25, 2021 • edited Loading

Codecov Report

wildart commented Dec 25, 2021

pcjentsch commented Sep 8, 2022

ararslan commented Sep 10, 2022

pcjentsch commented Sep 23, 2022 • edited Loading

alyst left a comment

Choose a reason for hiding this comment

alyst commented Mar 19, 2023

codecov-commenter commented Dec 25, 2021 •

edited

Loading

pcjentsch commented Sep 23, 2022 •

edited

Loading