Basic extractors #114
Closed
Basic extractors #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
reviewed
Nov 13, 2024
| error("$(location.file):$(location.line): The type `$bound_type` has " * | ||
| "$(length(field_names)) fields but the pattern expects $len fields.") | ||
| end | ||
| is_type = !Base.isnothing(try_bind_type(location, T, input, binder)) |
There was a problem hiding this comment.
This line does no good if T is not a symbol. Perhaps
is_extractor = T isa Symbol && Base.isnothing(try_bind_type(location, T, input, binder))
gafter
reviewed
Nov 13, 2024
gafter
reviewed
Nov 13, 2024
| end | ||
|
|
||
| @testset "extractor function missing" begin | ||
| # Bar is neither a type nor an extractor function |
There was a problem hiding this comment.
Please test the location and text of the diagnostic.
gafter
reviewed
Nov 13, 2024
nystrom
commented
Nov 13, 2024
gafter
approved these changes
Nov 13, 2024
|
Closing in favor of #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple extractor implementation. Supports only positional arguments for now. This is a strawman to work out the design.
Fixes #92