Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix precompilation #399

Merged
merged 3 commits into from
Nov 10, 2024
Merged

fix precompilation #399

merged 3 commits into from
Nov 10, 2024

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Nov 10, 2024

__init__ must be called in precompile_workload.

Also, use Base.get_have_truecolor if possible.

@t-bltg t-bltg added the bug label Nov 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.31%. Comparing base (ae99e73) to head (146b3ba).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/common.jl 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   99.75%   98.31%   -1.45%     
==========================================
  Files          36       36              
  Lines        2078     2074       -4     
==========================================
- Hits         2073     2039      -34     
- Misses          5       35      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-bltg t-bltg merged commit 389a27b into JuliaPlots:main Nov 10, 2024
9 checks passed
@t-bltg t-bltg deleted the fix-init branch November 10, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants