-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.9 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where `xxx` are `electrons` and `holes` and `x` is `e` and `h`. This will avoid confusion when people are trying to pass diffusion COEFFICIENTS instead of effective field vectors to the simulation.
In `_drift_charge!`, diffusion was modelled by adding an effective field vector to the external electric field and the electric field given by self-repulsion. For small Δt, the effective field vectors for diffusion would be very large, resulting in saturated behaviour in the drift velocity calculation. As the saturation is heavily dependent on the choice of Δt, diffusion is now modelled by adding fixed-step vectors after calculating the step vectors from the physical electric fields.
Update the diffusion implementation
This method only works if the applied potentials are of type `Int`, but it should also work for floating precision.
Add bisection method for `estimate_depletion_voltage`
Force the contacts to have consecutive IDs starting from 1
Diffusion parameters will be `De` and `Dh` instead of the previous `diffusion_fieldvector_electrons` and `diffusion_fielvector_holes`.
Add warning when using deprecated material properties format.
Update and add materials in `MaterialProperties.jl`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the release of SolidStateDetectors.jl v0.9.0 with the following breaking changes:
material_properties
rather than some effective electric field vectors (Update the diffusion implementation #335). This change is breaking as the format ofmaterial_properties
changed and the results might be different, as diffusion is not favoured towards thez
direction anymore as it used to be before.estimate_depletion_voltage
#336). This also affected the keyword arguments which makes this a breaking change.