Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthogonalize materialize for tribanded #393

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 25, 2023

Instead of defining separate methods for each combination of L/U and UNIT, we may instead read the parameters from the type inside a common method.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (7f123af) 89.43% compared to head (63a8633) 89.44%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   89.43%   89.44%   +0.01%     
==========================================
  Files          25       25              
  Lines        3510     3516       +6     
==========================================
+ Hits         3139     3145       +6     
  Misses        371      371              
Files Changed Coverage Δ
src/generic/matmul.jl 81.20% <100.00%> (+0.78%) ⬆️
src/lapack.jl 89.09% <100.00%> (ø)
src/tribanded.jl 97.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 20aada1 into JuliaLinearAlgebra:master Aug 25, 2023
16 checks passed
@jishnub jishnub deleted the tribandedortho branch August 25, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant