Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw in cholesky if check=false #389

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 2, 2023

Fix JuliaLinearAlgebra/ArrayLayouts.jl#100

This mirrors the behavior in LinearAlgebra, and after this, the following are consistent:

julia> B = BandedMatrix(-3=> 2ones(2), -1=>ones(4), 0=>2ones(5)); Buplo = :L; SB = Symmetric(B, Buplo);

julia> cholesky(Matrix(SB), check = false)
Failed factorization of type Cholesky{Float64, Matrix{Float64}}

julia> cholesky(SB, check = false)
Failed factorization of type Cholesky{Float64, BandedMatrix{Float64, Matrix{Float64}, Base.OneTo{Int64}}}

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7f123af) 89.43% compared to head (3e41c33) 89.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files          25       25           
  Lines        3510     3510           
=======================================
  Hits         3139     3139           
  Misses        371      371           
Files Changed Coverage Δ
src/lapack.jl 89.09% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 0ea04c9 into JuliaLinearAlgebra:master Aug 2, 2023
16 checks passed
@jishnub jishnub deleted the isposdefcheck branch August 2, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cholesky should not error with check=false
1 participant