-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ReferenceTests.jl #22
Conversation
After this PR is merged, I will create a new one to migrate to GitHub Actions. |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 72 72
=========================================
Hits 72 72 Continue to review full report at Codecov.
|
I wonder if we can also run the tests in the other platforms? Currently I am only running the reference tests on Linux via the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I noticed that you have deleted some tests for color images, which was a failure in #14 (I'm not sure if it's an ImageInpainting or ReferenceTests issue). Since this package never does a serious test on color images, it's okay to keep it as it is. However, as a package under JuliaImages, it's expected that ImageInpainting
should work with different color images seamlessly, so improvements are needed, which, of course, can be placed in future PRs.
Does ReferenceTests.jl handle different image formats in different platforms?
Images are loaded via image IO backends, so it's expected to have the same result if they have the same backend installed. For example, if and only if ImageMagick
is used.
This package never supported color types. There is an open issue #13 for anyone interested in adding the functionality. I don't have the time at the moment, but I'd be happy to review a future PR. I will merge this one as it solves the VisualRegressionTests.jl issue 👍🏽 |
Fixes #21
ReferenceTests.jl is a much cleaner approach compared to VisualRegressionTests.jl 👍🏽