Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReferenceTests.jl #22

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Use ReferenceTests.jl #22

merged 1 commit into from
Feb 2, 2021

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Feb 2, 2021

Fixes #21

ReferenceTests.jl is a much cleaner approach compared to VisualRegressionTests.jl 👍🏽

@juliohm
Copy link
Member Author

juliohm commented Feb 2, 2021

After this PR is merged, I will create a new one to migrate to GitHub Actions.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #22 (fa08aa6) into master (4f55d10) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           72        72           
=========================================
  Hits            72        72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f55d10...fa08aa6. Read the comment docs.

@juliohm
Copy link
Member Author

juliohm commented Feb 2, 2021

I wonder if we can also run the tests in the other platforms? Currently I am only running the reference tests on Linux via the visualtests variable defined in runtests.jl Does ReferenceTests.jl handle different image formats in different platforms?

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I noticed that you have deleted some tests for color images, which was a failure in #14 (I'm not sure if it's an ImageInpainting or ReferenceTests issue). Since this package never does a serious test on color images, it's okay to keep it as it is. However, as a package under JuliaImages, it's expected that ImageInpainting should work with different color images seamlessly, so improvements are needed, which, of course, can be placed in future PRs.

Does ReferenceTests.jl handle different image formats in different platforms?

Images are loaded via image IO backends, so it's expected to have the same result if they have the same backend installed. For example, if and only if ImageMagick is used.

@juliohm
Copy link
Member Author

juliohm commented Feb 2, 2021

Sorry for the delay. I noticed that you have deleted some tests for color images, which was a failure in #14 (I'm not sure if it's an ImageInpainting or ReferenceTests issue)

This package never supported color types. There is an open issue #13 for anyone interested in adding the functionality. I don't have the time at the moment, but I'd be happy to review a future PR.

I will merge this one as it solves the VisualRegressionTests.jl issue 👍🏽

@juliohm juliohm merged commit 3f890bc into master Feb 2, 2021
@juliohm juliohm deleted the reftests branch February 2, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are hanging due to Gtk.jl
2 participants