Adjust to Julia 1.12 change to implicit world age increment #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia 1.12 will no longer implicitly increment world ages within expressions. However, we will likely retain world age increments between statements of a `@testset`, so all that's needed here is to move the `load` to a separate like. More explicitly, the `collect`s could be `invokelatest`'ed instead.
Drvi
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM!
Linking this comment as it directly addresses this package: JuliaLang/julia#56509 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia 1.12 will no longer implicitly increment world ages within expressions. However, we will likely retain world age increments between statements of a
@testset, so all that's needed here is to move theloadto a separate like. More explicitly, thecollects could beinvokelatest'ed instead. See JuliaLang/julia#56509