Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat note re File/Stream #309

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Add compat note re File/Stream #309

merged 1 commit into from
Mar 8, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Mar 8, 2021

@timholy
Copy link
Member Author

timholy commented Mar 8, 2021

CC @devmotion

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #309 (125a3fb) into master (8778bea) will decrease coverage by 2.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   89.40%   87.05%   -2.36%     
==========================================
  Files          10       10              
  Lines         623      556      -67     
==========================================
- Hits          557      484      -73     
- Misses         66       72       +6     
Impacted Files Coverage Δ
src/types.jl 87.23% <ø> (-1.01%) ⬇️
src/mimesave.jl 64.70% <0.00%> (-13.08%) ⬇️
src/deprecated.jl 40.90% <0.00%> (-11.27%) ⬇️
src/registry_setup.jl 94.84% <0.00%> (-2.46%) ⬇️
src/query.jl 94.54% <0.00%> (-1.36%) ⬇️
src/error_handling.jl 78.94% <0.00%> (-1.06%) ⬇️
src/registry.jl 86.76% <0.00%> (-1.00%) ⬇️
src/loadsave.jl 98.52% <0.00%> (-0.21%) ⬇️
src/FileIO.jl 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8778bea...125a3fb. Read the comment docs.

@devmotion
Copy link

Thanks, looks good! Hopefully it helps others to avoid the mistake I made 🙂

@timholy timholy merged commit b779539 into master Mar 8, 2021
@timholy timholy deleted the teh/doc_compat branch March 8, 2021 14:15
@timholy
Copy link
Member Author

timholy commented Mar 8, 2021

It's not a mistake if it's not documented...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants