Precompute A^-1/n
and A^-n
in DislocationCreep
and DiffusionCreep
#207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing
A^-1/n
orA^-n
is really expensive, particularly during the pseudo-transient iterations where this is redundantly done thousands of times. In this PR we just precompute and store those values in the correspondentstruct
s.It results in a ~30% speedup in
JustRelax.jl
(example for a 64x64 model)TODO: units make it type unstable in some Julia versions