Add unordered transduce for channels #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 88.68% 88.57% -0.11%
==========================================
Files 18 19 +1
Lines 1131 1173 +42
==========================================
+ Hits 1003 1039 +36
- Misses 128 134 +6
Continue to review full report at Codecov.
|
tkf
commented
Jan 3, 2020
| @spawn begin | ||
| acc = acc′′ | ||
| for _ in 1:basesize | ||
| x = maybe_popfirst!(input) |
There was a problem hiding this comment.
Maybe interleaving I/O (popfirst!(::Channel)) and computation (next(xf, ...)) is bad for performance (e.g., SIMD cannot be used this way)? This should probably be done outside the reduction loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tkf/Transducers.jl/blob/1f8d35d287d5d773da836b3abfe4054bf0d012e0/src/unordered.jl#L115-L141