Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiagent vs. union performance docs for Julia 1.11 #1091

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Oct 10, 2024

The new timings are much more similar in 1.11, see https://juliadynamics.github.io/Agents.jl/dev/performance_tips/#multi_vs_union. But @multiagent has still the edge

@Tortar
Copy link
Member Author

Tortar commented Oct 10, 2024

The last commit makes the benchmark not allocating, @multiagent is now 2x faster than a union on that for Julia 1.11

@Datseris
Copy link
Member

I've been seeing performance regressions all across the board with 1.11. In compile time and run time... I suggest that we wait for 1.11.1 fix first before considering this seriously.

@Tortar
Copy link
Member Author

Tortar commented Oct 10, 2024

that seems good to me, but I'm skeptical about that making a big difference in compile times, I think it will take more than 1 release to improve this substantially, run times seems better to me on 1.11 instead

@Tortar
Copy link
Member Author

Tortar commented Oct 17, 2024

1.11.1 is out and it didn't improve much the state of Julia 1.11 release, I think it will take a fair amount of time to fix the compile issues of 1.11

@Datseris
Copy link
Member

ah, damn, to move to 1.11 we need to change OSM Visualizations, that's where teh failure comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants