-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Creates templates for ECS and EC2 testing #71
Conversation
Can you explain this in detail please? |
DeployGroupName: | ||
Value: !Ref DeployGroup | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can get rid of extra blank lines
Currently, we have functions in The
Both these templates can be launched as nested stacks through |
This proposed CodeDeploy setup should be detailed and demonstrated before anything is added to this repo. This approach creates a lot more complexity in the test infrastructure and needs to be fully evaluated. Alternatives should also be considered. One I can think of would be creating the EC2/ECS compute resources on demand and running tests on them using One thing to note: the cost for running a
Why Batch and not ECS directly?
Huh? Whatever is done for EC2/ECS credential testing should be run every time. |
For our purposes yes, but others who aren't working directly on the credentials-related code will probably not want to spin up the additional nested stacks for local testing. It's probably easier for them not to have to worry about packaging the templates. Any automated deployment will be set up to test ECS/EC2 every time.
ECS seems to be set up to run continuous services. We could launch the tests as a task, but ECS doesn't provide very good output for whether a task completed successfully or not. It expects it to run forever, and so just keeps track of whether it's running or not. AWS Batch runs through an ECS cluster, and provides better output as to success or failure. |
After some fiddling I've got a minimal example of using CodeDeploy using the ec2_test stack here. CodeDeploy has the ability to grab code straight from github, which simplifies the setup a little bit. The AWS User for the branch was created with
If you can point me to an appropriate cluster manager (preferably not using AWSCore), I'd be happy to give that approach a shot. |
The built-in SSH cluster manager combined with awscli would work without AWSCore |
72: Adds testing on ec2 r=iamed2 a=morris25 A second attempt at EC2 testing from #71. In response to #66. A proof of concept run can be found here https://travis-ci.org/morris25/Example.jl/builds/513200046 Co-authored-by: morris25 <[email protected]>
In response to #66