Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocking tests for instance credentials #66

Open
rofinn opened this issue Feb 7, 2019 · 3 comments
Open

Mocking tests for instance credentials #66

rofinn opened this issue Feb 7, 2019 · 3 comments
Assignees
@mattBrzezinski
Labels
v2
Milestone
AWSCore v2.0

Comments

@rofinn
Copy link
Member

rofinn commented Feb 7, 2019 •
edited
Loading

We should add Mocking.jl as a test dependency once that package switches to using Cassette. This will be helpful in testing credential searching logic (particularly instance credentials), as noted in #65.
@rofinn
Copy link
Member Author

rofinn commented Feb 7, 2019

Alternatively, we could just setup our public amazon account to support testing inside ECS tasks and on EC2 instances.

@morris25
Copy link
Contributor

If we were to launch tests on our public amazon account, what would a minimal stack for testing look like?

@morris25 morris25 mentioned this issue Mar 4, 2019
Closed
@rofinn
Copy link
Member Author

rofinn commented Mar 5, 2019

I'm not super familiar with this package, but I'd expect to test credentials for ECS tasks and ECS instances which currently aren't tested. I think for now we could create a stack that only uses free tier instances for ECS and EC2 tests.

@morris25 morris25 mentioned this issue Mar 29, 2019
Merged
bors bot added a commit that referenced this issue Apr 9, 2019
@bors
Merge #72
fb75c4d 
72: Adds testing on ec2 r=iamed2 a=morris25

A second attempt at EC2 testing from #71.
In response to #66.

A proof of concept run can be found here https://travis-ci.org/morris25/Example.jl/builds/513200046 

Co-authored-by: morris25 <[email protected]>
@morris25 morris25 mentioned this issue Apr 12, 2019
Merged
bors bot added a commit that referenced this issue Apr 22, 2019
@bors
Merge #77
cec5477 
77: Adds testing on ECS r=iamed2 a=morris25

A cleaned up version of ECS testing from #71.
In response to #66.

Co-authored-by: morris25 <[email protected]>
@mattBrzezinski mattBrzezinski self-assigned this Jan 30, 2020
@mattBrzezinski mattBrzezinski added this to the AWSCore v2.0 milestone Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattBrzezinski mattBrzezinski

Labels
v2
Projects
None yet
Milestone
AWSCore v2.0
Development

No branches or pull requests
3 participants
@mattBrzezinski @rofinn @morris25