support ConstructionBase: constructorof and setproperties #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be non-controversial – implements a well-established interface with clear guarantees. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructArrays are quite involved types, it's infeasible for some generic machinery to know how to reconstruct them from their fields/properties. Thus this PR adds explicit support for both
constructorof()andsetproperties()from ConstructionBase. With these, all the packages that need to reconstruct arbitrary objects / rely on ConstructionBase already, can work with StructArrays as well.The implementation is short, but needs some care to get right. That's the benefit of having it in one place, with tests for handling of all simple and complex cases.
ConstructionBasehas already been a dependency ofStructArrays, no new deps added in this PR.