Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect computation of return_type of itr #287

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix incorrect computation of return_type of itr #287

merged 2 commits into from
Dec 6, 2023

Commits on Dec 4, 2023

  1. Fix incorrect computation of return_type of itr 

    The `itr` return type was assumed to be always the same as the first
element. This is false for many objects, such as Tuple. Additionally,
it was using a private API (Core.Compiler and
Core.Compiler.return_type) which are not stable across versions of
Julia and may return weird and unpredictable answers. Switch to using
the API in Base for this.
    @vtjnash
    vtjnash authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    15bb0c9 View commit details
    Browse the repository at this point in the history

  2. Update collect.jl

    @vtjnash
    vtjnash authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    58dfbfe View commit details
    Browse the repository at this point in the history