Fix behavior of copy and similar (#12)

JuliaArrays · Mar 27, 2024 · 9136dca · 9136dca
1 parent cf3928d
commit 9136dca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/ReadOnlyArrays.jl b/src/ReadOnlyArrays.jl
@@ -69,7 +69,7 @@ Base.iterate(x::ReadOnlyArray, args...) = iterate(x.parent, args...)
 
 Base.length(x::ReadOnlyArray) = length(x.parent)
 
-Base.similar(x::ReadOnlyArray) = similar(x.parent) |> ReadOnlyArray
+Base.similar(x::ReadOnlyArray) = similar(x.parent)
 
 Base.axes(x::ReadOnlyArray) = axes(x.parent)
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -51,6 +51,12 @@ end
         fa = f()
         @test fa isa ReadOnlyArray{Float64,2}
         @test fa == x
+
+        a = ReadOnly([1, 2])
+        @test typeof(similar(a)) === Vector{Int64}
+
+        @test copy(a) == [1, 2]
+        @test typeof(copy(a)) === Vector{Int64}
     end
 end