Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FluentWorklist.transfer method #57

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Jan 12, 2024

  • 🆕 Implements FluentWorklist.transfer, with wash_scheme: Optional[int]. If wash_scheme=None, a .flush() is used instead of a .wash().
  • 🚚 Tests of large volume handling were moved such that they can be reused for both worklist types.

FluentWorklist can now be used, and is also covered by tests.

To reuse them for Evo/Fluent worklist types.
@michaelosthege michaelosthege added the enhancement New feature or request label Jan 12, 2024
@michaelosthege michaelosthege self-assigned this Jan 12, 2024
With ``wash_scheme=None`` option.
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (394a740) 95.05% compared to head (1a72b6d) 95.37%.
Report is 1 commits behind head on master.

❗ Current head 1a72b6d differs from pull request most recent head 112cb67. Consider uploading reports for the commit 112cb67 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   95.05%   95.37%   +0.31%     
==========================================
  Files          18       18              
  Lines        1051     1102      +51     
==========================================
+ Hits          999     1051      +52     
+ Misses         52       51       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelosthege michaelosthege merged commit e964c87 into master Jan 16, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant